Skip to content

Generate and upload code coverage #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

antonblr
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Adds code coverage generation and reporting to Codecov back.

Which issue(s) this PR fixes:

Fixes #1532

Special notes for your reviewer:

Coverage reported on these paths only right now (as it was setup like that before): kubernetes/watch and kubernetes/config (passed with --cov args).

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Feb 11, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @antonblr!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 11, 2022
@yliaog
Copy link
Contributor

yliaog commented Feb 11, 2022

please squash the commits

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d5fffca). Click here to learn what that means.
The diff coverage is 92.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1700   +/-   ##
=========================================
  Coverage          ?   92.78%           
=========================================
  Files             ?       13           
  Lines             ?     1747           
  Branches          ?        0           
=========================================
  Hits              ?     1621           
  Misses            ?      126           
  Partials          ?        0           
Impacted Files Coverage Δ
kubernetes/base/config/__init__.py 55.55% <55.55%> (ø)
kubernetes/base/config/exec_provider.py 82.97% <82.97%> (ø)
kubernetes/base/config/kube_config.py 84.39% <84.39%> (ø)
kubernetes/base/config/incluster_config.py 95.45% <95.45%> (ø)
kubernetes/base/watch/watch.py 95.95% <95.95%> (ø)
kubernetes/base/config/kube_config_test.py 96.08% <96.08%> (ø)
kubernetes/base/config/incluster_config_test.py 97.84% <97.84%> (ø)
kubernetes/base/config/dateutil.py 97.91% <97.91%> (ø)
kubernetes/base/watch/watch_test.py 98.06% <98.06%> (ø)
kubernetes/base/config/exec_provider_test.py 98.66% <98.66%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fffca...b2bf0f9. Read the comment docs.

@antonblr
Copy link
Contributor Author

Squashed and disabled Codecov comments (via codecov.yml).

@yliaog
Copy link
Contributor

yliaog commented Feb 11, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antonblr, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5e39789 into kubernetes-client:master Feb 11, 2022
@antonblr antonblr deleted the fix-codecov branch February 11, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov badge shows 0% coverage
4 participants