-
Notifications
You must be signed in to change notification settings - Fork 551
Expand the concept of the homeDir on Windows #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the concept of the homeDir on Windows #748
Conversation
Allow env vars HOME, HOMEDRIVE/HOMEPATH, and USERCONFIG to all denote a possible home directory Favor an existing .kube/config file Favor existing, writable home-ish directories And finally favor existing home-ish directories (which at this point aren't writable, but that's how the Kubernetes go-client does it). Use the same determination of the .kube/config-based home dir on Windows that the
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @ericpromislow! |
Also tighten up code to work with Node 12.
/assign @brendandburns |
@ericpromislow: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
78f64e1
to
ad25e51
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, ericpromislow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow env vars HOME, HOMEDRIVE/HOMEPATH, and USERCONFIG to all
denote a possible home directory (call these home-ish directories).
Favour an existing .kube/config file
Favour existing, writable home-ish directories
And finally favour existing home-ish directories (which at this
point aren't writable, but that's how the Kubernetes go-client
does it).
Use the same determination of the .kube/config-based home dir on Windows
that the Kubernetes go-client uses