-
Notifications
You must be signed in to change notification settings - Fork 551
docs: hosts autogenerated docs on GitHub Pages via Actions, updates README #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @mattxwang! |
/kind documentation |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mattxwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @brendandburns! I think there's one more step that we need to do, and I can't do it to this repository without admin privileges:
If you'd like, we could also add the link to the repository info section. |
This is now done. https://kubernetes-client.github.io/javascript/ If there are additional PRs to add links to the README feel free to send them along. Thanks! |
Hi @brendandburns, I'm not sure if the GitHub pages host is pointing to the right branch - https://kubernetes-client.github.io/javascript/ looks like it's just hosting the README currently, while https://mattxwang.github.io/javascript/ has the rest of the Typedoc UI (i.e. search bar, classes on the right, etc.) - would you be able to check that GitHub Pages is pointed at |
Hi! This is a relatively small PR that addresses #697. It does two things:
JamesIves/github-deploy-action
to push the output ofnpm run docs
to thegh-pages
branch, only on push tomaster
On top of merging this PR in, we would also need to manually enable pages, which can be done in Settings > Pages > Source > "gh-pages" (with
/
as the root). That would deploy the site to https://kubernetes-client.github.io/javascript/You can test my changes in the fork at https://mattxwang.github.io/javascript/
Let me know if there's anything else I should add/remove to this PR!
(as a follow up, I think it might be helpful to include the relevant versions for the docs somewhere on the site; that likely warrants a follow-up PR)