Use the public npm registry

[dominykas]

Should fix #594

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @dominykas!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[dominykas]

I signed it

[drubin]

hi @dominykas welcome :) and thanks for jumping in and fixing this.

As you can see this was added in #510 which both @brendandburns and I reviewed. I think this must have slipped through the cracks. We should add a CI check to ensure only the public registry is used but quick googling didn't show up any built in configs to ensure this.

Similar to https://docs.npmjs.com/cli/v6/configuring-npm/package-json#publishconfig but for pulling of NPM packages.

I am curious to know why these tests kept passing in CI though.

/lgtm
/assign @brendandburns

[dominykas]

We should add a CI check to ensure only the public registry is used but quick googling didn't show up any built in configs to ensure this.

Indeed I'm not aware of a thing that can enforce this, short of writing your own lint tool... Which is why I created an RRFC in npm to cover this case: npm/rfcs#340.

Maybe someone already has a linter for that 🤷‍♂️ It shouldn't be hard to create one.

[brendandburns]

Thanks for the PR, apologies for letting this slip in.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dominykas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment