chore: readd ws as a dependency #2442
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like people having issues due to the removal of ws https://github.com/kubernetes-client/javascript/commit/b727c7be7fc7c7a8cb5663d6d621d92027d47fc1\#r156475449 It would be good if there would be another way than to reintroduce the dependency but I don't really know how and at the same time I don't think it's good to have every consumer install ws separately.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
cjihrig
approved these changes
May 19, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like people having issues due to the removal of ws b727c7be7fc7c7a8cb5663d6d621d92027d47fc1\#r156475449
It would be good if there would be another way than to reintroduce the dependency but I don't really know how and at the same time I don't think it's good to have every consumer install ws separately.