Generate code for 1.32 #2105
Generate code for 1.32 #2105
Conversation
Signed-off-by: Kubernetes Prow Robot <k8s.ci.robot@gmail.com>
|
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: no
| import {BaseAPIRequestFactory, RequiredError, COLLECTION_FORMATS} from './baseapi.js'; | ||
| import {Configuration} from '../configuration.js'; | ||
| import {RequestContext, HttpMethod, ResponseContext, HttpFile, HttpInfo} from '../http/http.js'; | ||
| import {BaseAPIRequestFactory, RequiredError, COLLECTION_FORMATS} from './baseapi'; |
There was a problem hiding this comment.
It looks like the update is removing the recently added file extensions, which ESM requires. Is kubernetes-client/gen@b461333 being used (maybe I did something wrong when I did the update last time)?
There was a problem hiding this comment.
oh, my bad on the code review of #2062 we need to update the github action. I'll send a PR.
There was a problem hiding this comment.
hrm, let me take a look. we may need to update the github action. I sent #2106
There was a problem hiding this comment.
Maybe this line in the GitHub Action needs to be updated as well - https://github.com/kubernetes-client/javascript/blob/release-1.x/.github/workflows/generate-javascript.yml#L13.
There was a problem hiding this comment.
That's just the default which can be overridden on every run, but would make sense to update as well.
|
Closing this PR, I will re-open a different one with a fresh generation. |
cc @cjihrig