src: replace Promise chains with async/await #2053
Conversation
This helps with readability of the code. It also removed some Promises that were not not needed.
k8s-ci-robot
added
cncf-cla: yes
src/log.ts
Outdated
| ); | ||
| } | ||
| } catch (err: any) { | ||
| throw new ApiException<undefined>(err, 'Error occurred in log request', undefined, err); |
There was a problem hiding this comment.
Note - this line is ported from the previous catch() call, but I don't think passing err as the first parameter is actually correct. catch() typed err as any. When I changed to a try...catch, that typing was not there and TypeScript complained that the first argument should be a numeric code (probably similar to how src/metrics.ts does it).
There was a problem hiding this comment.
Yeah, I'm on board with switching this to match metric.ts
|
This basically looks good to me, one response to your query, but happy to merge as-is if you prefer, |
|
I've updated the |
|
/lgtm Thanks 🚀 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This helps with readability of the code. It also removed some Promises that were not not needed.