Skip to content

Automated Generate from openapi release-1.29 #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

No description provided.

Signed-off-by: Kubernetes Prow Robot <k8s.ci.robot@gmail.com>
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign davidgamero for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 26, 2024
@brendandburns brendandburns reopened this Mar 27, 2024
@mstruebing
Copy link
Member

I'm not sure and dig not into why it's failing here, but could the failing CI be because of this change: https://github.com/kubernetes-client/javascript/pull/1627/files ?

@brendandburns
Copy link
Contributor

@mstruebing actually, I had to pull out that cherry-pick because the initial check-out was for that revision. Without that PR, the github action fails:
https://github.com/kubernetes-client/javascript/actions/runs/8402732984

The errors look like an actual problem w/ the generated code. I'll dig into it a little more.

@brendandburns
Copy link
Contributor

I think the bulk of the errors are caused by this:
OpenAPITools/openapi-generator#14793

@brendandburns
Copy link
Contributor

Closing in favor of #1633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants