Skip to content

IntOrString type broke in 0.16.2  #771

Closed
@pascal-cloudnatix

Description

@pascal-cloudnatix

Describe the bug
It seems that in the latest tag 0.16.2 intOrString type is broken again. In the 0.16.1 tag the IntOrString type was fixed.
Related issues:

Seems like this commit 1f79306 undid the work done in this commit d44fa64

** Client Version **
0.16.2

To Reproduce

  1. Install version 0.16.1 and check file @kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
    V1PodDisruptionBudgetSpec should look like this:
export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: IntOrString;
    'minAvailable'?: IntOrString;
}
  1. Install version 0.16.2 and check file @kubernetes/client-node/dist/gen/model/v1PodDisruptionBudgetSpec.d.ts
    V1PodDisruptionBudgetSpec now looks like this, which removes the fixed type in 0.16.1
export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: object;
    'minAvailable'?: object;
}

Expected behavior
Generated type should be:

export declare class V1PodDisruptionBudgetSpec {
    'maxUnavailable'?: IntOrString;
    'minAvailable'?: IntOrString;
}

Environment (please complete the following information):

  • OS: MacOs
  • NodeJS Version 16

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions