Skip to content

Feat/kubectl rollout history statefulset #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NeverRaR
Copy link
Contributor

feat : support kubectl rollout history for statefulset

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2021
@NeverRaR NeverRaR force-pushed the feat/kubectl-rollout-history-statefulset branch 2 times, most recently from 1a0da95 to 4ce22a3 Compare August 13, 2021 10:40
@yue9944882
Copy link
Member

/hold

lets hold before #1818 b/c they're similar

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@NeverRaR NeverRaR force-pushed the feat/kubectl-rollout-history-statefulset branch 9 times, most recently from cf4bbb5 to 20a9bb5 Compare August 23, 2021 07:58
@NeverRaR NeverRaR force-pushed the feat/kubectl-rollout-history-statefulset branch from 20a9bb5 to 20b539d Compare August 23, 2021 08:04
@NeverRaR
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@NeverRaR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NeverRaR NeverRaR force-pushed the feat/kubectl-rollout-history-statefulset branch from 20b539d to 1fc1f4f Compare August 23, 2021 08:29
@NeverRaR NeverRaR force-pushed the feat/kubectl-rollout-history-statefulset branch from c45350f to c5d9b5b Compare August 25, 2021 10:55
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 25, 2021
@yue9944882
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeverRaR, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit cc09486 into kubernetes-client:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants