Skip to content

Fixes reflector list expiration #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fixes reflector list expiration #1543

merged 1 commit into from
Feb 18, 2021

Conversation

yue9944882
Copy link
Member

Fixes: #1533

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2021
@yue9944882
Copy link
Member Author

/cc @tony-clarke-amdocs

@brendandburns i suppose we should pick this back to 10 and 11 release, on which branch should open the cherry-picking pull?

@k8s-ci-robot
Copy link
Contributor

@yue9944882: GitHub didn't allow me to request PR reviews from the following users: tony-clarke-amdocs.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tony-clarke-amdocs

@brendandburns i suppose we should pick this back to 10 and 11 release, on which branch should open the cherry-picking pull?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yue9944882 yue9944882 force-pushed the fix/reflector-list-expiration branch from 61e8d4d to 013a9b7 Compare February 18, 2021 09:55
@tony-clarke-amdocs
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tony-clarke-amdocs: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsyer
Copy link

dsyer commented Feb 18, 2021

Master is beyond 11.0 now right (it has the breaking changes in the time API)? So we need to bump master to 12.0.0-SNAPSHOT and backport this change to 11.0 (at least).

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1999545 into kubernetes-client:master Feb 18, 2021
@brendandburns
Copy link
Contributor

@yue9944882

The right branches are release-10 and release-11

Thanks!

@yue9944882 yue9944882 mentioned this pull request Feb 22, 2021
Merged
@brendandburns brendandburns mentioned this pull request Mar 8, 2021
Closed
aaruna
aaruna reviewed Mar 27, 2021
View reviewed changes
util/src/test/java/io/kubernetes/client/informer/cache/ReflectorRunnableTest.java
.thenReturn(
new V1PodList().metadata(new V1ListMeta().resourceVersion(expectedResourceVersion)));
// constantly failing watches will make the reflector run only one time
when(listerWatcher.watch(any())).thenThrow(new ApiException(HttpURLConnection.HTTP_GONE, ""));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the scenario wherein this API returns responseCode 200 but the body has an event that has status.code=410 ?
https://github.com/kubernetes-client/java/pull/1611/files#diff-31beacc81d066c2ab68de67a3587fee7bd7ef10d9ba42dc0a180b621751c6bffR226

@yue9944882 yue9944882 mentioned this pull request Mar 30, 2021
Merged
@aaruna aaruna mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaruna aaruna aaruna left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getRelistResourceVersion() is too old and causes infinite errors
6 participants
@yue9944882 @k8s-ci-robot @tony-clarke-amdocs @dsyer @brendandburns @aaruna