Adds support for loading a string config content in KubernetesClientConfiguration #83
Conversation
|
LGTM but I suggest support stream if string is supported |
|
Hey @tg123, that's a great suggestion, this way we can support multiple ingress cases. Great thanks to @ViniciusSouza who authored the changes and commit it. |
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
this file should not be checked in
There was a problem hiding this comment.
We've created a NuGet package with those changes and I have let it there by mistake.
fixed, by removing the folder.
src/KubernetesClient.csproj
Outdated
| @@ -11,6 +11,10 @@ | |||
|
|
|||
| <TargetFramework>netstandard1.4</TargetFramework> | |||
| <RootNamespace>k8s</RootNamespace> | |||
| <Version>1.1.0</Version> | |||
There was a problem hiding this comment.
We've created a NuGet package with those changes and I have let it there by mistake.
Fixed
src/KubernetesClient.csproj
Outdated
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <PackageVersion>0.2.0-beta</PackageVersion> | |||
| <PackageVersion>0.2.1-beta</PackageVersion> | |||
There was a problem hiding this comment.
maybe should be managed by @brendandburns
There was a problem hiding this comment.
We've created a NuGet package with those changes and I have let it there by mistake.
Fixed
| /// <returns>Instance of the <see cref="K8SConfiguration"/> class</returns> | ||
| private static K8SConfiguration LoadKubeConfig(Stream kubeconfig) | ||
| { | ||
| StreamReader sr = new StreamReader(kubeconfig); |
| return k8SConfiguration; | ||
| } | ||
|
|
||
| private static KubernetesClientConfiguration GetKubernetesClientConfiguration(ref string currentContext, string masterUrl, K8SConfiguration k8SConfig) |
There was a problem hiding this comment.
Visual Studio´s refactoring.. fixed.
|
I'm happy to merge this once @tg123 's comments are addressed. |
|
@tg123 and @brendandburns, all fixed! |
|
LGTM, @tg123 any more comments? |
|
LGTM. better to do a squash merge |
allantargino
force-pushed
the
allantargino/config-string
branch
from
2c32f51 to
d24a72b
Compare
|
Squashed 👍 |
|
Thanks, merging. |
|
@tg123 fwiw, github now supports "squash and merge" so there's no need for the author to squash... |
Hi guys,
fixes #82
As related on the mentioned issue, we needed this feature in order to don't create temp files in our server.
Does the changes I've made make sense?
Thanks