Constructors that take a HttpClient do not work with Watch behaviors

[akrock]

In researching potential workarounds for #533 I was attempting to use the constructors where I could supply my own HttpClient.

These constructors appear to be non functional with the Watch behaviors and will hang and then eventually hit a timeout after 100 seconds. This appears to be due to some of the specialized logic that gets evaluated when the Kubernetes client constructs it's own HttpClient.

csharp/src/KubernetesClient/Kubernetes.ConfigInit.cs

Line 166 in 97ed40c

private void CreateHttpClient(DelegatingHandler[] handlers)

To meet what I would expect as a consumer of the library, one of the following should happen:

1. Constructors that are not fully compatible with all functionality of the library would not be externally available.
2. Any HttpClient with any configuration passed to the library is able to be used. This assumes that either the code is refactored to not require special changes to the HttpClient or it applies the needed changes in a way that is safe to all HttpClients.
3. Tools that can be used externally from the library to properly prepare a HttpClient for use with the library are provided, and the constructors that consume a HttpClient validate that the HttpClient is "prepared" for use with the library, and all of this is heavily documented.

[tg123]

have to install the WatchHandler in order the get watch work

I am trying to hack into stub generator part to solve such kind of issue

[akrock]

Yeah I saw that DelegatingWatchHandler that they were adding...

csharp/src/KubernetesClient/WatcherDelegatingHandler.cs

Line 15 in 97ed40c

internal class WatcherDelegatingHandler : DelegatingHandler

The problem with that is that it is internal to the assembly (so not externally available). If it were made public and documented it would help to achieve goal #3.

[CarlosLanderas]

I faced this problem when building some unit tests with MockHttpClient and Kubernetes Client Library.
I did some dirty cheats to get this working with an HttpClient that is using a mocked http message handler:

var messageHandler = new MockHttpMessageHandler(BackendDefinitionBehavior.Always);

new Kubernetes(MockKubernetesConfiguration.GetTestConfiguration(), new HttpClient(GetKubernetesWatcherDelegatingHandler(messageHandler)))

 private static DelegatingHandler GetKubernetesWatcherDelegatingHandler(HttpMessageHandler innerHandler)

        {
            var watcherHandler = typeof(IKubernetes).Assembly.GetTypes().First(t => t.Name.Contains("WatcherDelegatingHandler"));
            var instance = Activator.CreateInstance(watcherHandler) as DelegatingHandler;
            instance.InnerHandler = innerHandler;
            return instance;
        }

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.