Handling of negative DECIMAL numbers (mariadb) seems erronous

[dominiquegerber]

Please provide the following details.

• Operating System: Linux
• PHP Version: 8.0
• php-mysql-replication Version: 1.0.0
• *mysql version : 10.3.22-MariaDB-1:10.3.22+maria~bionic-log mariadb.org binary distribution

Steps required to reproduce the problem.

CREATE TABLE test(field DECIMAL(11,4));
INSERT INTO TEST(-57.1234);

Actual Result.

In RowEvent.php line 665:

bcmul(): Argument #1 ($num1) is not well-formed

I have taken a look at the "RowEvent" where the fault occurs. Printing out the offending argument shows that it is indeed malformed : -57.-1234. The negative is applied to both integral and fractional parts, hence the problem. Removing the XOR of the value didn't solve the issue completely, so I "abs" the values and this worked.

I don't know the intricacies of binlogs good enough to be sure that my fix is good —tbh the ABS() seems like a hack to me...— but if it is I can make a pull request for it to be integrated into the project.

[krowinski]

Good one I trying to replicate and I got

        $create_query = 'CREATE TABLE test (test DECIMAL(11,4))';
        $insert_query = 'INSERT INTO test VALUES(-57.1234)';

MySQLReplication/Event/RowEvent/RowEvent.php:665:
string(10) "-57.-64302"

I got negative and 64302 not 1234 🤯
But other test for decimals are working... 😭

meh will try to fix this later

[dominiquegerber]

Thanks for having a look at this ! The "abs" is obviously a hack, it doesn't even really work correctly as you pointed out. I may have a better solution, a pull request has been opened.

[krowinski]

Tx for fix gj