Ext url5 test #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Pattern There is a ZPP arginfo violation because the empty return or error return is not always properly handled. And there is also a memory leak if creating the regular expression instance fails. Closes phpGH-18438.
* PHP-8.3: datefmt_parse/datefmt_localtime references type system fixes Fix phpGH-18438: Handling of empty data and errors in ZipArchive::addPattern
* PHP-8.4: Fix IntlDateFormatter::parseToCalendar() reference type system breaks datefmt_parse/datefmt_localtime references type system fixes Fix phpGH-18438: Handling of empty data and errors in ZipArchive::addPattern
Measure levenshtein for grapheme cluster unit
--ignore-platform-reqs may accidentally install versions of dependencies that no longer support the given PHP version. --ignore-platform-req=php+ will only suppress errors for new PHP version but not change behavior for older versions. Thanks to Tim for the hint. Also skip the Laravel build for PHP 8.1, which is no longer supported on Laravel's default branch.
* PHP-8.1: Use --ignore-platform-req=php+ in community build
* PHP-8.2: Use --ignore-platform-req=php+ in community build
* PHP-8.3: Use --ignore-platform-req=php+ in community build
* PHP-8.4: Use --ignore-platform-req=php+ in community build
* PHP-8.3: Fix build on Apple Clang 17+ (php#18629)
* PHP-8.4: Fix build on Apple Clang 17+ (php#18629)
Introduces intl_convert_utf8_to_utf16_zstr() to convert a UTF-8 string to a UTF-16 string zend_string* instance. This way we avoid a double copy later from a UChar* into a zend_string*.
delaying the object creation only before ldap initialisation. fix forgotten url freeing on TLS error code path. close phpGH-18645
An always enabled lexbor extension is added, containing the lexbor library that was separated from ext/dom extension in preparation of https://wiki.php.net/rfc/url_parsing_api. While at it, the lexbor library is upgraded to 2.5.0. Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Co-authored-by: Gina Peter Banyard <girgias@php.net>
This avoids dereferences by Z_ARRVAL_P().
[ci skip] This is already tested in 016.phpt.
might have been a relic of past modifications, but pushing it down to the actual first case of error path.
Add recursion protection when emitting deprecation warnings for class constants, since the deprecation message can come from an attribute that is using the same constant for the message, or otherwise result in recursion. But, internal constants are persisted, and thus cannot have recursion protection. Otherwise, if a user error handler triggers bailout before the recursion flag is removed then a subsequent request (e.g. with `--repeat 2`) would start with that flag already applied. Internal constants can presumably be trusted not to use deprecation messages that come from recursive attributes. Fixes phpGH-18463 Fixes phpGH-17711
* PHP-8.4: Reapply phpGH-17712 with a fix for internal class constants (php#18464)
* use zend_simd.h in zend_accelerator_util_funcs.c * use zend_simd.h in mbstring * Remove unnecessary SSE3 includes
Show warning when saving session if a pipe character is used in one of the $_SESSION keys Fixes php#18634
Destroy the old value first. We can't skip recreating the value because the object may have been changed in between calls. Closes phpGH-18624.
* PHP-8.3: Fix memory leak in tidy output handler on error Fix leaks with multiple calls to DatePeriod iterator current()
* PHP-8.4: Fix memory leak in tidy output handler on error Fix leaks with multiple calls to DatePeriod iterator current()
This led to recursion being added to but not removed from internal constants.
kocsismate
pushed a commit
that referenced
this pull request
Jun 10, 2025
```
ext/gd/libgd/gd.c:2275:14: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
#0 0x5d6a2103e1db in php_gd_gdImageCopy /home/dcarlier/Contribs/php-src/ext/gd/libgd/gd.c:2275
#1 0x5d6a210a2b63 in gdImageCrop /home/dcarlier/Contribs/php-src/ext/gd/libgd/gd_crop.c:57
#2 0x5d6a21018ca4 in zif_imagecrop /home/dcarlier/Contribs/php-src/ext/gd/gd.c:3575
#3 0x5d6a21e46e7a in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1337
#4 0x5d6a221188da in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:57246
#5 0x5d6a221366bd in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:61634
#6 0x5d6a21d107a6 in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1895
php#7 0x5d6a21a63409 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2529
php#8 0x5d6a22516d5e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:966
php#9 0x5d6a2251981d in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1341
php#10 0x7f10d002a3b7 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
php#11 0x7f10d002a47a in __libc_start_main_impl ../csu/libc-start.c:360
php#12 0x5d6a20a06da4 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2806da4) (BuildId: d9a79c7e0e4872311439d7313cb3a81fe04190a2)
```
close phpGH-18006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.