Upgrade to Symfony 4

[theofidry]

As Symfony 4 is out I think it's best to switch to 4.x instead of 3.4@dev.

[kocsismate]

Yeah, thank you very much! I still only used 3.4 because last time I wanted to try an optimization (I believe this one: symfony/symfony#25474) and I could only find it in the 3.4 dev branch back then.

[kocsismate]

@theofidry I was told months before that Symfony DI works best with lower-case definition ID-s. Is this still the case?

Because I had to change the container configuration while upgrading to v4 to use FQCN-s as definition ID-s as the previous config didn't work anymore: 0f5f111#diff-8acfe3ece5e377f24d9b270cef51a907L53

So could you tell me what the most optimal setup is for Symfony?

[theofidry]

I’m not sure, I think it should be ok in both cases :)

…

On Wed 24 Jan 2018 at 22:55, Máté Kocsis ***@***.***> wrote: @theofidry <https://github.com/theofidry> I was told months before that Symfony DI works best with lower-case definition ID-s. Is this still the case? Because I had to change the container configuration while upgrading to v4 to use FQCN-s as definition ID-s as the previous config didn't work anymore: 0f5f111#diff-8acfe3ece5e377f24d9b270cef51a907L53 <0f5f111#diff-8acfe3ece5e377f24d9b270cef51a907L53> So could you tell me what the most optimal setup is for Symfony? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE76gcmIZokOUZiUqcMFrWbTZ8572Gz8ks5tN7T0gaJpZM4RrlDd> .

[kocsismate]

Ok then I won't try to change it. For the record this is the original discussion about the topic: #8

[theofidry]

Oh I see. Apparently the micro-optim is still valid: it's not faster with or without lower-case definition IDs, but it is if you respect the case as if it doesn't, Symfony DI will be able to find the service but has to do further lookups