Parcoords: ellipsize long labels; show full text in tooltip #1

kernc · 2017-05-18T17:50:14Z

Ellipsizes labels that are too long to prevent overlapping. But always show full label text in mouse hover tooltip.

Before

After

- as now gl2d traces now come with cartesian svg layers (for select/lasso modes)

- hoveron was added *just* to make scatter/hover.js not break, it's functionality was never implemented in scattergl.

- this brings back first render for 1e6 pts in close to 1500ms - add relayout logic so that updating into dragmode select/lasso triggers a recalc.

- ... to make image test pass

- there's no need

- to compare output with better gl2d tick patch

This reverts commit d63578b.

- instead of 'old' mesure that uses glplot.viewBox - this makes gl2d ticks 'more on-par' with SVG

I don't understand why we need to initInteractions twice, but it seems necessary to do both before and after finalDraw

standardize on assets/delay and increase the updateCamera delay

if you mouseout of the gl2d plot while hovering on a point, this ensures that unhover will be triggered. prior to this the test "scattergl after visibility restyle" consistently failed for me locally

seems like chrome has a more efficient image encoder now

- a follow-up to plotly#448

- use graph-wide <g.zoomlayer> for ternary zoom effects, no need to another layer to accomplish this.

- broken since plotly#448 - 🔒 down with test

Fix scatterternary lasso/select drag modes

- so we might be able to reuse them for contourcarpet - and test getVisibleSegment

minor change to the algorithm probably due to cleaner open/closed criterion

this makes contours.coloring='lines' work with carpet also fixes some unusual bugs like if the first contour is not shown that were fixed long ago for contour

same as contour - it's *probably* ok without this but I'm a little worried about some restyle call changing element order unexpectedly.

also a bugfix to findBestTextLocation - surprised that didn't break anything before!

Contour line labels

kernc · 2017-07-06T15:39:06Z

@monfera Could you have a quick look at this? It's only five lines or so.

monfera · 2017-07-06T18:17:49Z

@kernc thanks for the PR, I see it's been around for quite some time. I'm on another task now, will check back with you ASAP.

monfera · 2017-07-06T18:39:38Z

@kernc your PR didn't register with us b/c it's a PR toward your own repo rather than the upstream (ie. it doesn't show up here: https://github.com/plotly/plotly.js/pulls) - there are some key issues, please issue the PR toward the plotly org as it's a better place for comments

kernc · 2017-07-06T18:45:16Z

I was just following your PR guidelines which state:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, ...

Will open a PR there, thanks.

monfera · 2017-07-06T18:48:11Z

Indeed, you're right! I saw the PR is dated May 18 and saw no conversation.

kernc · 2017-07-06T18:49:21Z

Some conversation took place in plotly#1703. 😃

Continued in plotly#1857.

kernc force-pushed the parcoords-ellipsize branch from f286da9 to 5269c30 Compare May 18, 2017 18:22

kernc mentioned this pull request May 18, 2017

Parallel coordinates plot axes labels overlap plotly/plotly.js#1703

Closed

etpinard and others added 28 commits June 6, 2017 16:36

don't try to remove selection elements when zoomlayer does not exist

3a30ae1

fixup 'scatter' -> addTraces 'scattergl' test

1c61a47

- as now gl2d traces now come with cartesian svg layers (for select/lasso modes)

Ignore overcalculating snap-points

9f57eff

bring back scattergl marker colorscale

c60fb1d

🔪 hoveron in scattergl

3921fdd

- hoveron was added *just* to make scatter/hover.js not break, it's functionality was never implemented in scattergl.

Fix scatter-fancy lasso

07b4c7c

fill scattergl calcdata only when dragmode is set to select/lasso

6ac722d

- this brings back first render for 1e6 pts in close to 1500ms - add relayout logic so that updating into dragmode select/lasso triggers a recalc.

don't try to style plot bg in gl2d case

2ceede1

- ... to make image test pass

don't try to style grid lines either

33dda89

don't draw cartesian framework on top of gl2d subplots in staticPlot

baabafe

- there's no need

[tmp] replace 'scattergl' traces w/ 'scatter'

d63578b

- to compare output with better gl2d tick patch

[tmp] generate 'scattergl' -> 'scatter' baselines

fbeb5e9

Revert "[tmp] replace 'scattergl' traces w/ 'scatter'"

7e79eb1

This reverts commit d63578b.

use ax._length from setScale in gl2d

3d67177

- instead of 'old' mesure that uses glplot.viewBox - this makes gl2d ticks 'more on-par' with SVG

generate gl2d baselines with better ticks

32efccd

axis.constrain and axis.constraintoward

d0af01b

robustify plot_test

cc705c3

simplify plot_test

b3a3bb7

robustify plot_api_test

27fc2a9

simplify hover_label_test

d937732

no really, initInteractions! fix plotly#1044... again

1570274

I don't understand why we need to initInteractions twice, but it seems necessary to do both before and after finalDraw

robustify drawing_test

72896ec

robustify gl_plot_interact_test

ee3211a

standardize on assets/delay and increase the updateCamera delay

streamline gl2d_click_test

f12ff73

fix bug with unhover in gl2d

5f5214e

if you mouseout of the gl2d plot while hovering on a point, this ensures that unhover will be triggered. prior to this the test "scattergl after visibility restyle" consistently failed for me locally

robustify mapbox_test

9df6903

seems like chrome has a more efficient image encoder now

tests of axis domain constraints

d0b15c8

create constraints.clean to get it out of the main Plotly.plot code

d67829e

etpinard and others added 21 commits June 28, 2017 15:38

rename variable plot to more appropriate zoomLayer

14ae77c

- a follow-up to plotly#448

rm ternary-only zoom layer

ec6e360

- use graph-wide <g.zoomlayer> for ternary zoom effects, no need to another layer to accomplish this.

DRY up select_test.js

e3a2c84

fix select/lasso on ternary subplots

4bbbe5c

- broken since plotly#448 - 🔒 down with test

add select/lasso for scattercarpet traces

5a48568

Merge pull request plotly#1831 from plotly/fix-scatterternary-lasso

70de159

Fix scatterternary lasso/select drag modes

refactor contour/plot for smaller functions

fb4b690

- so we might be able to reuse them for contourcarpet - and test getVisibleSegment

updated contour_edge_cases baseline

b0f9bb2

minor change to the algorithm probably due to cleaner open/closed criterion

unify contour.style and contourcarpet.style

e1caa9e

this makes contours.coloring='lines' work with carpet also fixes some unusual bugs like if the first contour is not shown that were fixed long ago for contour

cover contour edge cases with contourcarpet

0ff2dc4

fix contour style when coloring=none

f5873f1

a little more stuff contourcarpet can inherit from contour

b5a674f

fix carpet plot clip path

1f85a6f

🔪 some obsolete code in carpet/plot

6c2043e

update histogram2dcontour for contour.plot API change

bbb9574

nest scattercontour lines inside a contourlines group

9495dee

same as contour - it's *probably* ok without this but I'm a little worried about some restyle call changing element order unexpectedly.

fixup font->labelfont in contourcarpet

7f086e0

labels on contourcarpet

49b8141

also a bugfix to findBestTextLocation - surprised that didn't break anything before!

update comment on contourcarpet label bounds

8934038

update baselines for findBestTextLocation bugfix

dbeecd0

Merge pull request plotly#1815 from plotly/contour-labels

fbc0296

Contour line labels

Parcoords: ellipsize long labels; show full text in tooltip

a28e116

kernc force-pushed the parcoords-ellipsize branch from 5269c30 to a28e116 Compare July 6, 2017 18:44

kernc closed this Jul 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Parcoords: ellipsize long labels; show full text in tooltip #1

Parcoords: ellipsize long labels; show full text in tooltip #1

Uh oh!

kernc commented May 18, 2017

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

Uh oh!

Parcoords: ellipsize long labels; show full text in tooltip #1

Parcoords: ellipsize long labels; show full text in tooltip #1

Uh oh!

Conversation

kernc commented May 18, 2017

Before

After

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

monfera commented Jul 6, 2017

Uh oh!

kernc commented Jul 6, 2017

Uh oh!

Uh oh!