Fixed __maybe_resample_data freq performance #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that black has formatted the code differentially and I cannot get flake8 to get working on my machine. Any help is more than welcome. Thanks. |
|
Certainly prefer patches that are functionally minimal. Black is very opinionated. What troubles flake8 on your machine? Should be a simple |
|
I have fixed the formatting of the code. Are there any other issues? By the way, Flake8 did not work for me because of some compatibility problem with pycodestyle==2.7.0. So I had to downgrade it to 2.3.1. |
kernc
reviewed
Aug 2, 2021
kernc
reviewed
Aug 2, 2021
|
Many thanks for illustrating this alternative approach! 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318 for more information. First time submitting a pull request. Any feedback is appreciated!