Refactor f-string formatting. #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
previously approved these changes
Nov 1, 2020
backtesting/_plotting.py
Outdated
Comment on lines
428
to
429
| f"(index datetime resolution: '{time_resolution}'). " | ||
| "Skipping.", |
There was a problem hiding this comment.
Suggested change
| f"(index datetime resolution: '{time_resolution}'). " | |
| "Skipping.", | |
| f"(index datetime resolution: '{time_resolution}'). Skipping.", |
backtesting/backtesting.py
Outdated
Comment on lines
427
to
428
| If size is a value between 0 and 1, it is interpreted as a fraction | ||
| of current available liquidity (cash plus `Position.pl` minus used margin). |
There was a problem hiding this comment.
Suggested change
| If size is a value between 0 and 1, it is interpreted as a fraction | |
| of current available liquidity (cash plus `Position.pl` minus used margin). | |
| If size is a value between 0 and 1, it is interpreted as a fraction of current | |
| available liquidity (cash plus `Position.pl` minus used margin). |
backtesting/backtesting.py
Outdated
| assert 0 < cash, "cash shosuld be >0, is {}".format(cash) | ||
| assert 0 <= commission < .1, "commission should be between 0-10%, is {}".format(commission) | ||
| assert 0 < margin <= 1, "margin should be between 0 and 1, is {}".format(margin) | ||
| assert 0 < cash, f"cash shosuld be >0, is {cash}" |
There was a problem hiding this comment.
Suggested change
| assert 0 < cash, f"cash shosuld be >0, is {cash}" | |
| assert 0 < cash, f"cash should be >0, is {cash}" |
backtesting/backtesting.py
Outdated
Comment on lines
708
to
709
| raise ValueError(f"Long orders require: " | ||
| f"SL ({sl}) < LIMIT ({limit or stop or self.last_price}) < TP ({tp})") |
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"Long orders require: " | |
| f"SL ({sl}) < LIMIT ({limit or stop or self.last_price}) < TP ({tp})") | |
| raise ValueError( | |
| "Long orders require: " | |
| f"SL ({sl}) < LIMIT ({limit or stop or self.last_price}) < TP ({tp})") |
The usual style guidelines say either hanging or indented, but not mixed. Thought flake8 catches that. 🤔
backtesting/backtesting.py
Outdated
Comment on lines
712
to
713
| raise ValueError(f"Short orders require: " | ||
| f"TP ({tp}) < LIMIT ({limit or stop or self.last_price}) < SL ({sl})") |
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"Short orders require: " | |
| f"TP ({tp}) < LIMIT ({limit or stop or self.last_price}) < SL ({sl})") | |
| raise ValueError( | |
| "Short orders require: " | |
| f"TP ({tp}) < LIMIT ({limit or stop or self.last_price}) < SL ({sl})") |
|
Would you care to rebase on / merge in the current master? The PR went out of sync. Also welcome to address the proposed amendments. 😁 |
Goblincomet
pushed a commit
to Goblincomet/forex-trading-backtest
that referenced
this pull request
Jul 5, 2023
Fixes: kernc/backtesting.py#161 Closes: kernc/backtesting.py#166 Thanks @Alex-CodeLab Squashed commit of the following: commit 363641d2b827957338ff338564323ebf1ee0e98e Merge: aad278c 773a85f Author: Kernc <kerncece@gmail.com> Date: Thu Nov 12 21:35:41 2020 +0100 Merge branch 'master' commit aad278cb1fe3f206a011817ac9047afc737eb70d Author: Kernc <kerncece@gmail.com> Date: Thu Nov 12 20:42:30 2020 +0100 add some more f-strings where useful commit 4fd6ac51b54a924791fee34c49301fe5618d3769 Author: Kernc <kerncece@gmail.com> Date: Thu Nov 12 20:24:08 2020 +0100 address comments commit 5ab6cb343d768a3874407b85b7bf7c8dd2c6f743 Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 19:40:57 2020 +0100 Update _plotting.py commit 00bb39e5d24f0fd1e47e94062d87ce268834c8cc Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 19:40:02 2020 +0100 Update backtesting.py commit 6c633bcbccd750960d5e5219a6d09b890f3c1639 Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 19:35:55 2020 +0100 Update backtesting.py commit 732068a6a5a3d152584ae32179a355b3611bb6a9 Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 19:26:55 2020 +0100 Update backtesting.py commit 21fed39e3e323cc399194f9e3d4485fb01182346 Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 19:19:25 2020 +0100 Update backtesting.py commit e0b929e308996f41df81ff8339bce94adf4a53aa Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 18:49:30 2020 +0100 Update backtesting.py commit 696669a71f90a355d44d61c4f0e53510b2e68163 Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 18:02:10 2020 +0100 Update backtesting.py commit e38b25f3e7afdfccd5e9aa5fdf5241b95f9cc78c Author: Alex ⚡ <1678423+Alex-CodeLab@users.noreply.github.com> Date: Sat Oct 31 17:42:43 2020 +0100 Update backtesting.py commit 6bd749296ddc9e5202c7765dde0a79323eda2e9b Author: alex <alex.sd3@gmail.com> Date: Sat Oct 31 16:29:38 2020 +0100 Refactor f-string formating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use f-string formatting where useful.
Fixes #161