-
Notifications
You must be signed in to change notification settings - Fork 17
fixes list issue #44 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes list issue #44 #46
Conversation
…space index to informer Signed-off-by: Premkumar Bhaskal <bpremkumar@vmware.com>
Hi @prembhaskal. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
can i get a needs-ok-to-test and review on this? |
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: ac6419fac217ad9ef6d3492ab7c56a0fdd828168
|
@sttts could you please review this? |
Seems like this is fixing the same problem as #45, just much better. Thank you! /lgtm |
@stevekuznetsov @sttts PTAL when you get time. thank you. |
hmm I think it needs an approve label. Do we need approval from all or multiple owners from here https://github.com/kcp-dev/controller-runtime/blob/kcp-1.28/DOWNSTREAM_OWNERS for that to happen? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #44
adding the cluster and cluster-and-namespace index to informer