Skip to content

fixes list issue #44 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

prembhaskal
Copy link

fixes #44
adding the cluster and cluster-and-namespace index to informer

…space index to informer

Signed-off-by: Premkumar Bhaskal <bpremkumar@vmware.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2024
@kcp-ci-bot
Copy link

Hi @prembhaskal. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 1, 2024
@prembhaskal prembhaskal changed the title fixes list issue #44 , adding the cluster and cluster-and-namespace i… fixes list issue #44 Feb 1, 2024
@prembhaskal
Copy link
Author

can i get a needs-ok-to-test and review on this?

@mjudeikis
Copy link

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2024
@mjudeikis
Copy link

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: ac6419fac217ad9ef6d3492ab7c56a0fdd828168

@prembhaskal
Copy link
Author

@sttts could you please review this?

@embik
Copy link
Member

embik commented Feb 7, 2024

Seems like this is fixing the same problem as #45, just much better. Thank you!

/lgtm

@prembhaskal
Copy link
Author

@stevekuznetsov @sttts PTAL when you get time. thank you.

@prembhaskal
Copy link
Author

hmm I think it needs an approve label. Do we need approval from all or multiple owners from here https://github.com/kcp-dev/controller-runtime/blob/kcp-1.28/DOWNSTREAM_OWNERS for that to happen?

@sttts
Copy link
Member

sttts commented Feb 15, 2024

/approve

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@kcp-ci-bot kcp-ci-bot merged commit a1a470c into kcp-dev:kcp-1.28 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller runtime client list fails with error "Index with name cluster does not exist"
6 participants