Add Indexer plumbing, add kcp indexers by default #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
add-indexer-plumbing
branch
from
1db7775 to
2108c00
Compare
|
I'm guessing there will be an additional change to use these indexers? |
|
whoops meant to make this a draft, yeah looking into the listers atm |
ncdc
reviewed
May 31, 2022
pkg/cache/internal/cache_reader.go
Outdated
| // TODO(kcp), should we just require people to pass in the cluster list option, or maybe provide | ||
| // a wrapper that adds it from the context automatically rather than doing this? | ||
| // It may also make more sense to just use the context and not bother provided a ListOption for it | ||
| if listOpts.Cluster.String() == "" { |
There was a problem hiding this comment.
Suggested change
| if listOpts.Cluster.String() == "" { | |
| if listOpts.Cluster.Empty() { |
pkg/cache/internal/cache_reader.go
Outdated
| @@ -125,10 +137,12 @@ func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...cli | |||
| // namespaced index key. Otherwise, ask for the non-namespaced variant by using the fake "all namespaces" | |||
| // namespace. | |||
| objs, err = c.indexer.ByIndex(FieldIndexName(field), KeyToNamespacedKey(listOpts.Namespace, val)) | |||
| case listOpts.Cluster.String() == "": | |||
There was a problem hiding this comment.
Suggested change
| case listOpts.Cluster.String() == "": | |
| case listOpts.Cluster.Empty(): |
| @@ -488,6 +492,14 @@ func (m MatchingFieldsSelector) ApplyToDeleteAllOf(opts *DeleteAllOfOptions) { | |||
| m.ApplyToList(&opts.ListOptions) | |||
| } | |||
|
|
|||
| // InCluster restricts the list/delete operation to the given cluster. | |||
There was a problem hiding this comment.
Could this ultimately go into a kcp repo instead of controller-runtime?
| var objs []interface{} | ||
| var err error | ||
|
|
||
| listOpts := client.ListOptions{} | ||
| listOpts.ApplyOptions(opts) | ||
|
|
||
| // TODO(kcp), should we just require people to pass in the cluster list option, or maybe provide | ||
| // a wrapper that adds it from the context automatically rather than doing this? | ||
| // It may also make more sense to just use the context and not bother provided a ListOption for it |
There was a problem hiding this comment.
I maybe think I prefer the ListOption, especially if it's in a kcp repo instead of controller-runtime. I'm not sure that would work with the live client easily, though, as that needs the context?
3 tasks
fabianvf
force-pushed
the
add-indexer-plumbing
branch
from
9c36bda to
bad30ba
Compare
ncdc
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.