Controller-runtime allows building kcp-aware controllers #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
reviewed
May 25, 2022
pkg/cache/cache_test.go
Outdated
| @@ -26,7 +26,6 @@ import ( | |||
| . "github.com/onsi/ginkgo" | |||
| . "github.com/onsi/ginkgo/extensions/table" | |||
| . "github.com/onsi/gomega" | |||
|
|
|||
ncdc
reviewed
May 25, 2022
pkg/cache/internal/cache_reader.go
Outdated
| @@ -54,7 +54,7 @@ type CacheReader struct { | |||
| } | |||
|
|
|||
| // Get checks the indexer for the object and writes a copy of it if found. | |||
| func (c *CacheReader) Get(_ context.Context, key client.ObjectKey, out client.Object) error { | |||
| func (c *CacheReader) Get(ctx context.Context, key client.ObjectKey, out client.Object) error { | |||
fabianvf
force-pushed
the
make-kcp-aware
branch
2 times, most recently
from
0ed834f to
d2929c2
Compare
ncdc
reviewed
May 25, 2022
pkg/client/apiutil/apimachinery.go
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2018 The Kubernetes Authors. | |||
| opyright 2018 The Kubernetes Authors. | |||
ncdc
reviewed
May 25, 2022
pkg/client/watch.go
Outdated
| @@ -33,10 +33,12 @@ func NewWithWatch(config *rest.Config, options Options) (WithWatch, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
Co-authored-by: Joe Lanford <joe.lanford@gmail.com> Co-authored-by: Varsha Prasad <varshaprasad96@gmail.com> Co-authored-by: Andy Goldstein <andy.goldstein@redhat.com> Co-authored-by: Nick Hale <njohnhale@gmail.com>
ncdc
approved these changes
May 25, 2022
kcp-ci-bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.