Skip to content

Optionally disallow "WIP", "Merge" ( and fixup! / squash!) #101

Open
@Narretz

Description

@Narretz

These exceptions are hard-coded in https://github.com/jzaefferer/commitplease/blob/cec0dd6d28ed1ec42843285192072877830c1f96/lib/validate.js as far as I can see.

This is okay when a commit range gets reviewed before merging, but to be 100% strict, you should be able to turn off any of this in specific circumstances / make it overwritable like the config)

For example, in Angular / AngularJS merge commits are actually disallowed - everything must be rebased and the merge commit must be squashed.

We are also adding commitplease to Travis in AngularJS and fixup! and squash! are okay, but WIP isn't

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions