`@TempDir` field in super class skipped when it has same name as a `@TempDir` field in subclass

[sbrannen]

Overview

After fixing #3498, I realized that the same types of bugs exist for finding fields in a type hierarchy.

The fix for fields should be analogous to the fix for methods: apply field predicate before searching type hierarchy.

Example

SuperclassTempDirTests passes, but SubclassTempDirTests fails unless you rename one of the @TempDir fields to something other than tempDir.

package demo.a;

import static org.assertj.core.api.Assertions.assertThat;

import java.nio.file.Path;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

public class SuperclassTempDirTests {

	@TempDir
	static Path tempDir;

	protected static Path getStaticTempDir() {
		return tempDir;
	}

	@Test
	void superTest() {
		assertThat(getStaticTempDir()).exists();
	}

}

package demo.b;

import static org.assertj.core.api.Assertions.assertThat;

import java.nio.file.Path;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

import demo.a.SuperclassTempDirTests;

class SubclassTempDirTests extends SuperclassTempDirTests {

	@TempDir
	Path tempDir;

	Path getInstanceTempDir() {
		return this.tempDir;
	}

	@Test
	void subTest() {
		assertThat(getInstanceTempDir()).exists();
		assertThat(getStaticTempDir()).exists();
	}

}

Related Issues

• @BeforeAll method in super class skipped when it has same name as a @BeforeEach method in subclass #3498

Deliverables

• Apply field predicate before searching type hierarchy.

[sbrannen]

Tentatively slated for inclusion in 5.10.1; however, if we don't have time to fix it before the release, we may decide to postpone the fix for a subsequent 5.10.x or the 5.11.0 release.

@marcphilipp, I've already submitted PR #3533 (which contains some TODOs), but if I don't complete it before you release 5.10.1 perhaps you can take it over.

[sbrannen]

• see PR Apply field predicate before searching type hierarchy #3533