Skip to content

fix: remove unnecessary schema from jsx-no-comment-textnodes #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: remove unnecessary schema from jsx-no-comment-textnodes #2340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/rules/jsx-no-comment-textnodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ module.exports = {
url: docsUrl('jsx-no-comment-textnodes')
},

schema: [{
type: 'object',
properties: {},
additionalProperties: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like it'd be a breaking change, in case someone had already been providing an empty object - also, the purpose of this schema is to make it easy for people to add new properties (without being forced to suddenly add the object)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per #2341 - it's breaking in the strictest sense.

I personally don't see the point in keeping an invalid schema in here. Keeping it for the just in case seems a bit silly, considering that it has been waiting for just in case for 3 years?

}]
schema: []
},

create(context) {
Expand Down