Handle isRequired for boolean-prop-naming

[louisscruz]

The Problem

There was a bug in boolean-prop-naming where the following would trip the rule:

class Something extends React.Component {
  static propTypes = {
    something: PropTypes.bool
  };
  // ...
}

but the following would not:

class Something extends React.Component {
  static propTypes = {
    something: PropTypes.bool.isRequired
  };
  // ...
}

The Solution

I added an extra conditional to getPropKey to handle this scenario.

[ljharb]

For both of the added tests, can you add a duplicate copy that parses with the default parser instead of babel-eslint?

[ljharb]

this can be return name; now?

[louisscruz]

@ljharb Absolutely. On it.

[louisscruz]

@ljharb Actually, just gave it a shot, and it seems that any test that uses class properties needs that parser. If I remove it, I get A fatal parsing error occurred: Parsing error: Unexpected token = (even for other tests in this file).

[rapheld]

Would love to see this get in

[ljharb]

@louisscruz indeed; the code examples using class properties would need to be tweaked so as not to use them.

[louisscruz]

@ljharb Oh, I see what you're getting at. Will add those.

[louisscruz]

@ljharb Added!

[ljharb]

Thanks!

[louisscruz]

@yannickcr Any chance you could publish this so I can get access to this bug fix by default?