-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[Docs] create setup.md
#1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tiefling
wants to merge
1
commit into
jsx-eslint:master
Choose a base branch
from
tiefling:tiefling-setup-docs-info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Docs] create setup.md
#1152
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,43 @@ | ||||||||||||||||||||||
In order to use the react eslint plugin do the following... | ||||||||||||||||||||||
|
||||||||||||||||||||||
1. At the root of your project type <code>npm install --save-dev eslint-plugin-react</code> | ||||||||||||||||||||||
2. Check your package.json 'devDependencies' for the following entries (version numbers may vary, but it's important that **the eslint version matches the peerDependency version in eslint-plugin-react**)... | ||||||||||||||||||||||
<pre> | ||||||||||||||||||||||
"devDependencies": { | ||||||||||||||||||||||
"eslint": "^7.3.1", | ||||||||||||||||||||||
"eslint-plugin-react": "^7.10.3" | ||||||||||||||||||||||
} | ||||||||||||||||||||||
</pre> | ||||||||||||||||||||||
3. If configuring using package.json add the following under 'eslintConfig'... | ||||||||||||||||||||||
<pre> | ||||||||||||||||||||||
"eslintConfig": { | ||||||||||||||||||||||
"plugins": [ | ||||||||||||||||||||||
"react" | ||||||||||||||||||||||
] | ||||||||||||||||||||||
} | ||||||||||||||||||||||
</pre> | ||||||||||||||||||||||
Else, in your eslint configuration file (.eslintrc) add the following... | ||||||||||||||||||||||
<pre> | ||||||||||||||||||||||
{ | ||||||||||||||||||||||
"plugins": [ | ||||||||||||||||||||||
"react" | ||||||||||||||||||||||
] | ||||||||||||||||||||||
} | ||||||||||||||||||||||
</pre> | ||||||||||||||||||||||
4. Configure the rules you want to use according to the [rules docs](/docs/rules). Here's a sample of some of mine... | ||||||||||||||||||||||
<pre> | ||||||||||||||||||||||
"eslintConfig": { | ||||||||||||||||||||||
"rules": { | ||||||||||||||||||||||
"no-unused-vars": 2, | ||||||||||||||||||||||
"react/jsx-uses-vars": 2, | ||||||||||||||||||||||
"react/require-extensions": 0, | ||||||||||||||||||||||
"react/jsx-sort-prop-types": 0, | ||||||||||||||||||||||
"react/prop-types": [2, { | ||||||||||||||||||||||
Comment on lines
+31
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
"ignore": ["children"], | ||||||||||||||||||||||
"skipUndeclared": false | ||||||||||||||||||||||
}] | ||||||||||||||||||||||
} | ||||||||||||||||||||||
} | ||||||||||||||||||||||
</pre> | ||||||||||||||||||||||
|
||||||||||||||||||||||
<i>You can read more about configuring ESLint plugins at http://eslint.org/docs/user-guide/configuring#configuring-plugins</i> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think maybe it'd be better to use instructions like here: https://github.com/airbnb/javascript/blob/c5bee75b1b358a3749f1a6d38ee6fad73de28e29/packages/eslint-config-airbnb-base/README.md#eslint-config-airbnb-base-1 so it's a bit more automated.