Skip to content

jsx-curly-brace-presence conflicts with no-unescaped-entities #3214

Closed
@ntkoopman

Description

@ntkoopman

With both jsx-curly-brace-presence and no-unescaped-entities turned on

<script>{`window.foo = "bar"`}</script>

is fixed into

<script>window.foo = "bar"</script>

which works fine, but will give a warning/error on no-unescaped-entities.

It is my understanding that jsx-curly-brace-presence should not be triggering on this code, since the documentation says:

If the rule is set to get rid of unnecessary curly braces(JSX expression) and there are characters that need to be escaped in its JSX form, such as quote characters, forbidden JSX text characters, escaped characters and anything that looks like HTML entity names, the code will not be warned because the fix may make the code less readable.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-brace-presence.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions