`react/jsx-closing-bracket-location` doesn't stick to indentation style

[Richienb]

See xojs/eslint-config-xo-react#31

[ljharb]

Can you reproduce the relevant content here please?

[Richienb]

This reproduction demonstrates that it is impossible to follow the tab-based indendation style while also following this rule.

[ljharb]

I see what you mean.

"tag-aligned" is not an option I use personally, nor the airbnb config uses, nor one I'd recommend - and precisely because of this kind of scenario, I'm not sure it's ever possible to make that work.

In other words, the only way to make this work would be to use some kind of heuristic - either "fall back to $otherConfigKind", or, "within one tab of the tag-aligned position", or, "ignore that line". None of those seem ideal.

What would you suggest?

[Richienb]

Perhaps this drawback should be documented along with other rules that need to be used.

[ljharb]

That would be a great improvement to the documentation to make what's implicit, explicit - that line-aligned and tag-aligned only work well when using spaces for indentation, because the line/tag often won't match a whole number of indentation levels.