fix: suggestion helper function

Author: himanshu007-creator

lib/rules/no-invalid-html-attribute.js

@@ -234,6 +234,21 @@ const messages = {
   spaceDelimited: '”{{attributeName}}“ attribute values should be space delimited.',
 };
 
+const fixModes = {
+  remove: 'remove',
+  replaceTextRange: 'removeTextRange',
+  removeRange: 'removeRange'
+}
+
+const fixMessages = {
+  removeDefault : '"remove {{attributeName}}"',
+  removeEmpty:'"remove empty attribute {{attributeName}}"',
+  removeInvalid: '“remove invalid attribute {{reportingValue}}”',
+  removeWhitespaces: 'remove whitespaces in “{{reportingValue}}”',
+
+
+}
+
 function splitIntoRangedParts(node, regex) {
   const valueRangeStart = node.range[0] + 1; // the plus one is for the initial quote
 
@@ -254,14 +269,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName },
-      suggest: [
-        {
-            desc: "To Be Replaced By Appropriate Message",
-            fix: function(fixer) {
-                return fixer.remove(parentNode);
-            }
-        }
-      ]
+      suggestion(fixMessages.removeNonString, fixer, fixModes.remove, parentNode)
     });
     return;
   }
@@ -270,14 +278,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
     report(context, messages.noEmpty, 'noEmpty', {
       node,
       data: { attributeName },
-      suggest: [
-        {
-            desc: "To Be Replaced By Appropriate Message",
-            fix: function(fixer) {
-                return fixer.remove(parentNode);
-            }
-        }
-      ]
+      suggestion(fixMessages.removeEmpty, fixer, fixModes.remove, attributeName)
     });
     return;
   }
@@ -293,14 +294,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
           attributeName,
           reportingValue,
         },
-        suggest: [
-          {
-              desc: "To Be Replaced By Appropriate Message",
-              fix: function(fixer) {
-                  return fixer.removeRange(singlePart.range);
-              }
-          }
-        ]
+        suggestion(fixMessages.removeInvalid, fixer, fixModes.removeRange, singlePart.range)
       });
     } else if (!allowedTags.has(parentNodeName)) {
       report(context, messages.notValidFor, 'notValidFor', {
@@ -310,14 +304,7 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
           reportingValue,
           elementName: parentNodeName,
         },
-        suggest: [
-          {
-              desc: "To Be Replaced By Appropriate Message",
-              fix: function(fixer) {
-                  return fixer.removeRange(singlePart.range);
-              }
-          }
-        ]
+        suggestion(fixMessages.removeInvalid, fixer, fixModes.removeRange, singlePart.range)
       });
     }
   }
@@ -357,27 +344,13 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
       report(context, messages.spaceDelimited, 'spaceDelimited', {
         node,
         data: { attributeName },
-        suggest: [
-          {
-              desc: "To Be Replaced By Appropriate Message",
-              fix: function(fixer) {
-                  return fixer.removeRange(whitespacePart.range);
-              }
-          }
-        ]
+        suggestion(fixMessages.removeWhitespaces, fixer, fixModes.removeRange, whitespacePart.range)
       });
     } else if (whitespacePart.value !== '\u0020') {
       report(context, messages.spaceDelimited, 'spaceDelimited', {
         node,
         data: { attributeName },
-        suggest: [
-          {
-              desc: "To Be Replaced By Appropriate Message",
-              fix: function(fixer) {
-                  return fixer.removeRange(whitespacePart.range, '\u0020');
-              }
-          }
-        ]
+        suggestion(fixMessages.removeWhitespaces, fixer, mofixModes.replaceTextRange, whitespacePart.range, '\u0020' )
       });
     }
   }
@@ -388,17 +361,23 @@ const DEFAULT_ATTRIBUTES = ['rel'];
 function checkAttribute(context, node) {
   const attribute = node.name.name;
 
-  function fix(fixer) {
-    return fixer.remove(node);
+  function fix(fixer, mode, ...args) {
+    if (mode === 'removeTextRange') {
+      return fixer.replaceTextRange(args)
+    }
+    else if (mode === 'removeRange') {
+      return fixer.removeRange(args)
+    }
+    else {
+      return fixer.remove(args)
+    }
   }
 
-  function suggestion(desc, fixer){
+  function suggestion(desc, fixer, mode, ...args) {
     return [
       {
-          desc: desc,
-          fix: function(fixer) {
-              return fixer.remove(node);
-          }
+        desc: desc,
+        fix(fixer, mode, args)
       }
     ]
   }
@@ -415,7 +394,7 @@ function checkAttribute(context, node) {
         attributeName: attribute,
         tagNames,
       },
-      suggest:suggestion("hehe"),
+      suggestion(fixMessages.removeDefault, fixer, fixModes.remove, attributeName)
     });
     return;
   }
@@ -424,7 +403,7 @@ function checkAttribute(context, node) {
     report(context, messages.emptyIsMeaningless, 'emptyIsMeaningless', {
       node,
       data: { attributeName: attribute },
-      suggest:suggestion("hehe"),
+      suggestion(fixMessages.removeEmpty, fixer, fixModes.removemode, attributeName)
     });
     return;
   }
@@ -445,7 +424,7 @@ function checkAttribute(context, node) {
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName: attribute },
-      suggest:suggestion("hehe"),
+      suggestion(fixMessages.removeDefault, fixer, fixModes.remove, attributeName)
     });
     return;
   }
@@ -454,7 +433,7 @@ function checkAttribute(context, node) {
     report(context, messages.onlyStrings, 'onlyStrings', {
       node,
       data: { attributeName: attribute },
-      suggest:suggestion("hehe"),
+      suggestion(fixMessages.removeDefault fixer, fixModes.remove, attributeName)
     });
   }
 }