Skip to content

Commit 3d9b43b

Browse files
fix: removed autofixer with suggestion
1 parent f83b388 commit 3d9b43b

File tree

1 file changed

+63
-22
lines changed

1 file changed

+63
-22
lines changed

lib/rules/no-invalid-html-attribute.js

Lines changed: 63 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,14 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
254254
report(context, messages.onlyStrings, 'onlyStrings', {
255255
node,
256256
data: { attributeName },
257-
fix(fixer) {
258-
return fixer.remove(parentNode);
259-
},
257+
suggest: [
258+
{
259+
desc: "To Be Replaced By Appropriate Message",
260+
fix: function(fixer) {
261+
return fixer.remove(parentNode);
262+
}
263+
}
264+
]
260265
});
261266
return;
262267
}
@@ -265,9 +270,14 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
265270
report(context, messages.noEmpty, 'noEmpty', {
266271
node,
267272
data: { attributeName },
268-
fix(fixer) {
269-
return fixer.remove(parentNode);
270-
},
273+
suggest: [
274+
{
275+
desc: "To Be Replaced By Appropriate Message",
276+
fix: function(fixer) {
277+
return fixer.remove(parentNode);
278+
}
279+
}
280+
]
271281
});
272282
return;
273283
}
@@ -283,9 +293,14 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
283293
attributeName,
284294
reportingValue,
285295
},
286-
fix(fixer) {
287-
return fixer.removeRange(singlePart.range);
288-
},
296+
suggest: [
297+
{
298+
desc: "To Be Replaced By Appropriate Message",
299+
fix: function(fixer) {
300+
return fixer.removeRange(singlePart.range);
301+
}
302+
}
303+
]
289304
});
290305
} else if (!allowedTags.has(parentNodeName)) {
291306
report(context, messages.notValidFor, 'notValidFor', {
@@ -295,9 +310,14 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
295310
reportingValue,
296311
elementName: parentNodeName,
297312
},
298-
fix(fixer) {
299-
return fixer.removeRange(singlePart.range);
300-
},
313+
suggest: [
314+
{
315+
desc: "To Be Replaced By Appropriate Message",
316+
fix: function(fixer) {
317+
return fixer.removeRange(singlePart.range);
318+
}
319+
}
320+
]
301321
});
302322
}
303323
}
@@ -337,17 +357,27 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
337357
report(context, messages.spaceDelimited, 'spaceDelimited', {
338358
node,
339359
data: { attributeName },
340-
fix(fixer) {
341-
return fixer.removeRange(whitespacePart.range);
342-
},
360+
suggest: [
361+
{
362+
desc: "To Be Replaced By Appropriate Message",
363+
fix: function(fixer) {
364+
return fixer.removeRange(whitespacePart.range);
365+
}
366+
}
367+
]
343368
});
344369
} else if (whitespacePart.value !== '\u0020') {
345370
report(context, messages.spaceDelimited, 'spaceDelimited', {
346371
node,
347372
data: { attributeName },
348-
fix(fixer) {
349-
return fixer.replaceTextRange(whitespacePart.range, '\u0020');
350-
},
373+
suggest: [
374+
{
375+
desc: "To Be Replaced By Appropriate Message",
376+
fix: function(fixer) {
377+
return fixer.removeRange(whitespacePart.range, '\u0020');
378+
}
379+
}
380+
]
351381
});
352382
}
353383
}
@@ -362,6 +392,17 @@ function checkAttribute(context, node) {
362392
return fixer.remove(node);
363393
}
364394

395+
function suggestion(desc, fixer){
396+
return [
397+
{
398+
desc: desc,
399+
fix: function(fixer) {
400+
return fixer.remove(node);
401+
}
402+
}
403+
]
404+
}
405+
365406
const parentNodeName = node.parent.name.name;
366407
if (!COMPONENT_ATTRIBUTE_MAP.has(attribute) || !COMPONENT_ATTRIBUTE_MAP.get(attribute).has(parentNodeName)) {
367408
const tagNames = Array.from(
@@ -374,7 +415,7 @@ function checkAttribute(context, node) {
374415
attributeName: attribute,
375416
tagNames,
376417
},
377-
fix,
418+
suggest:suggestion("hehe"),
378419
});
379420
return;
380421
}
@@ -383,7 +424,7 @@ function checkAttribute(context, node) {
383424
report(context, messages.emptyIsMeaningless, 'emptyIsMeaningless', {
384425
node,
385426
data: { attributeName: attribute },
386-
fix,
427+
suggest:suggestion("hehe"),
387428
});
388429
return;
389430
}
@@ -404,7 +445,7 @@ function checkAttribute(context, node) {
404445
report(context, messages.onlyStrings, 'onlyStrings', {
405446
node,
406447
data: { attributeName: attribute },
407-
fix,
448+
suggest:suggestion("hehe"),
408449
});
409450
return;
410451
}
@@ -413,7 +454,7 @@ function checkAttribute(context, node) {
413454
report(context, messages.onlyStrings, 'onlyStrings', {
414455
node,
415456
data: { attributeName: attribute },
416-
fix,
457+
suggest:suggestion("hehe"),
417458
});
418459
}
419460
}

0 commit comments

Comments
 (0)