Skip to content

Add possibility to register void methods as a JSON-RPC message #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add possibility to register void methods as a JSON-RPC message #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions include/jsonrpccxx/typemapper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ namespace jsonrpccxx {
constexpr json::value_t GetType(type<T>) {
return json::value_t::object;
}
constexpr json::value_t GetType(type<void>) { return json::value_t::null; }
constexpr json::value_t GetType(type<std::string>) { return json::value_t::string; }
constexpr json::value_t GetType(type<bool>) { return json::value_t::boolean; }
constexpr json::value_t GetType(type<float>) { return json::value_t::number_float; }
Expand Down Expand Up @@ -148,6 +149,22 @@ namespace jsonrpccxx {
//
// Mapping for classes
//
template <typename T, typename ReturnType, typename... ParamTypes>
MethodHandle methodHandle(ReturnType (T::*method)(ParamTypes...), T &instance) {
std::function<ReturnType(ParamTypes...)> function = [&instance, method](ParamTypes &&... params) -> ReturnType {
return (instance.*method)(std::forward<ParamTypes>(params)...);
};
return methodHandle(function);
}

template <typename T, typename... ParamTypes>
NotificationHandle notificationHandle(void (T::*method)(ParamTypes...), T &instance) {
std::function<void(ParamTypes...)> function = [&instance, method](ParamTypes &&... params) -> void {
return (instance.*method)(std::forward<ParamTypes>(params)...);
};
return notificationHandle(function);
}

template <typename T, typename ReturnType, typename... ParamTypes>
MethodHandle GetHandle(ReturnType (T::*method)(ParamTypes...), T &instance) {
std::function<ReturnType(ParamTypes...)> function = [&instance, method](ParamTypes &&... params) -> ReturnType {
Expand Down
12 changes: 12 additions & 0 deletions test/typemapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,18 @@ TEST_CASE("test class member binding", TEST_MODULE) {
CHECK(notifyResult == "Hello world: someone");
}

TEST_CASE("test class member explicit binding", TEST_MODULE) {
SomeClass instance;
MethodHandle mh = methodHandle(&SomeClass::add, instance);
CHECK(mh(R"([3, 4])"_json) == 7);

notifyResult = "";
NotificationHandle mh2 = notificationHandle(&SomeClass::notify, instance);
CHECK(notifyResult.empty());
mh2(R"(["someone"])"_json);
CHECK(notifyResult == "Hello world: someone");
}

TEST_CASE("test incorrect params", TEST_MODULE) {
SomeClass instance;
MethodHandle mh = GetHandle(&SomeClass::add, instance);
Expand Down