Skip to content

Ether/minor wording #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2020

Conversation

karenetheridge
Copy link
Member

very minor fixes to grammar and an xref link

@handrews
Copy link
Contributor

RFC xrefs actually work fine without text (although I should have used the <xref target="..." /> form to make the intent more clear. But we are inconsistent about it (the brackets happen when you don't provide text for the xref):

Screen Shot 2020-05-20 at 12 14 32 PM

I'm fine with changing it this way (and nice catch on the missing "a"s) but it should probably go on some consistency checklist somewhere for later review across the spec.

@karenetheridge
Copy link
Member Author

RFC xrefs actually work fine without text

Yup, I noticed when reading the marked up document that this link rendered differently (not badly, just differently) than all the others, and then saw why when I looked at the source. Inconsistencies bug me :)

@handrews
Copy link
Contributor

@karenetheridge I'm all in favor of resolving the inconsistencies. I suspect there are more like this, but that's no reason not to merge this one. I don't think anyone else will object so I'll go ahead and do that.

@handrews handrews merged commit ed69fd3 into json-schema-org:master May 20, 2020
@karenetheridge karenetheridge deleted the ether/minor-wording branch May 20, 2020 20:05
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants