Skip to content

Fix $anchor plain name format to match XML's NCName production #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020
Merged

Fix $anchor plain name format to match XML's NCName production #916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a6a29
Fix $anchor plain name format to match XML's NCName production
ssilverman May 9, 2020
fab4f8c
Update the NCName reference to an xref
ssilverman May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions jsonschema-core.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,9 +1391,11 @@
identifier keyword that can only be used to create plain name fragments.
</t>
<t>
If present, the value of this keyword MUST be a string, which MUST start with
a letter ([A-Za-z]), followed by any number of letters, digits ([0-9]),
hyphens ("-"), underscores ("_"), colons (":"), or periods (".").
If present, the value of this keyword MUST be a string and MUST start with
a letter ([A-Za-z]) or underscore ("_"), followed by any number of letters,
digits ([0-9]), hyphens ("-"), underscores ("_"), and periods (".").
This matches the US-ASCII part of XML's
<xref target="xml-names">NCName production</xref>.
<cref>
Note that the anchor string does not include the "#" character,
as it is not a URI-reference. An "$anchor": "foo" becomes the
Expand Down Expand Up @@ -3250,6 +3252,36 @@ https://example.com/schemas/common#/$defs/count/minimum
</front>
<seriesInfo name="Internet-Draft" value="draft-handrews-json-schema-hyperschema-02" />
</reference>
<reference anchor="xml-names" target="http://www.w3.org/TR/2006/REC-xml-names11-20060816">
<front>
<title>Namespaces in XML 1.1 (Second Edition)</title>
<author fullname="Tim Bray" role="editor">
<organization>Textuality</organization>
<address>
<email>tbray@textuality.com</email>
</address>
</author>
<author fullname="Dave Hollander" role="editor">
<organization>Contivo, Inc.</organization>
<address>
<email>dmh@contivo.com</email>
</address>
</author>
<author fullname="Andrew Layman" role="editor">
<organization>Microsoft</organization>
<address>
<email>andrewl@microsoft.com</email>
</address>
</author>
<author fullname="Richard Tobin" role="editor">
<organization>University of Edinburgh and Markup Technology Ltd</organization>
<address>
<email>richard@cogsci.ed.ac.uk</email>
</address>
</author>
<date month="August" year="2006"/>
</front>
</reference>
</references>

<section title="Schema identification examples" anchor="idExamples">
Expand Down