Improve contentEncoding RFC references #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relequestual
approved these changes
Feb 24, 2020
|
Would it be worth pointing out that the contentEncoding only makes sense if the string only consists of 7-bit characters? |
|
@awwright hmm... yeah that's reasonable. RFC 2045 explicitly gives the range as 7bit ASCII, and RFC 4648 specifies various subsets of that for its encodings. It doesn't really change anything, but emphasizes that Of course, those 7bit characters will still be encoded as UTF-8 in JSON, but that's fine. |
The reference to RFC 2045 was ambiguous and misleading. Emphasize RFC 4648 more, and clarify what from 2045 is relevant and when.
|
OK finally remembered to put in the bit about 7-bit strings, @awwright Also started the changelog and added an entry for the email format RFC update which is the only other change on this file so far. This should be ready to go now. |
awwright
approved these changes
Mar 23, 2020
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803. See this comment for an overview of what is going on.
The reference to RFC 2045 was ambiguous and misleading. Emphasize
RFC 4648 more, and clarify what from 2045 is relevant and when.
Also improved wording around the default behavior, lifting the notion of an
identity encoding from RFC 2045.