Skip to content

figure should be a child of section, not t. #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

figure should be a child of section, not t. #841

merged 1 commit into from
Jan 29, 2020

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Jan 28, 2020 •
edited
Loading

Fixes #834

@Relequestual Relequestual requested a review from handrews January 28, 2020 13:14
handrews
handrews approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if I did this anywhere else. I'm pretty sure I (clearly mistakenly) thought you could put <figure> inside of <t> so there might be more of these.

@Relequestual
Copy link
Member Author

I'll make a new issue for this

@Relequestual Relequestual mentioned this pull request Jan 29, 2020
Closed
@Relequestual Relequestual merged commit fd7f166 into json-schema-org:master Jan 29, 2020
@Relequestual Relequestual deleted the Fixes/834 branch January 29, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema Core - 11.3 - minor text editing error
2 participants
@Relequestual @handrews