Skip to content

Make sure xref is wrapped in t tag to fix #814 #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

Make sure xref is wrapped in t tag to fix #814 #839

merged 1 commit into from
Jan 29, 2020

Conversation

Relequestual
Copy link
Member

Looks like if you have a t tag with a list tag, you're not expected to have other tags at the same level.

I couldn't find the documentation to confirm this, but this change does seem to fix the issue.

handrews
handrews approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again- another one where we should probably look through to see if I did this in multiple places.

@Relequestual Relequestual mentioned this pull request Jan 29, 2020
Closed
@Relequestual
Copy link
Member Author

Good call. Noted

@Relequestual Relequestual merged commit e02c98e into json-schema-org:master Jan 29, 2020
@Relequestual Relequestual deleted the Fixes/814 branch January 29, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Relequestual @handrews