Skip to content

fix invalid JSON in 7.7.1.1. Distinguishing Among Multiple Values #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

notEthan
Copy link
Contributor

fix nesting and structure of JSON example. the existing JSON is indented incorrectly, contains a closing } with no corresponding { and doesn't parse.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @notEthan !

Just a really minor point- the awkward wrapping of the description fields is sadly necessary, could you please restore that part? I'll be happy to merge after that.

Also, feel free to add your name to the end of the "for their submissions and patches to the document." section of the Acknowledgements if you'd like.

"title": "Feature B",
"properties": {
"enabled": {
"description": "If set to null, Feature B inherits the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-wrap this the way it was before. The way this gets formatted in the plain text output this line ends up too wide.

"description": "Whether the feature is enabled (true),
disabled (false), or under
automatic control (null)",
"description": "Whether the feature is enabled (true), disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-wrap this the way it was before. The way this gets formatted in the plain text output this line ends up too wide.

@notEthan
Copy link
Contributor Author

I suspected messing with that might be a mistake. restored the original wrapping.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@handrews handrews merged commit 5df7ea8 into json-schema-org:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants