-
-
Notifications
You must be signed in to change notification settings - Fork 320
Fix verbose example to use $defs
#785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix verbose example to use $defs
#785
Conversation
This Verbose example is also missing the json-schema-spec/jsonschema-core.xml Lines 2750 to 2785 in c5a6078
|
This looks great to me- I'm just leaving it open to make sure @gregsdennis sees the question about Although for something like The idea being that people will probably write more human-friendly tools for analyzing verbose output rather than reading raw JSON, so they could render that error however they like. But noting the error against the @gregsdennis what are your feelings on this? We can open a separate issue if needed and merge this for now. |
Probably an oversight. I have no strong feels about fixing it here or in another PR. Additionally, I don't think that I required having an
👍 |
Follows on from 5b08871.