-
-
Notifications
You must be signed in to change notification settings - Fork 320
Deprecated clarfications around arrays #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think I fixed it? |
My feeling is that people will only look to use this if they know what they want to indicate. @philsturgeon Say the first item in |
@Relequestual some languages allow undefined array positions. But really it means "it won't look like this anymore soon", it does not say what it will look like. The default assumption is that it goes away, but you could also just use it to indicate an overall change. I guess. |
@philsturgeon @Relequestual what still needs to be done here? |
I am not sure, Ben thought there was further work to be done but I thought you answered his questions, so... break the deadlock with a thumb? Or, Ben, if you can let me know of a specific actionable thing?
…--
Phil Sturgeon
@philsturgeon
On Jul 11, 2019, at 22:50, Henry Andrews ***@***.***> wrote:
@philsturgeon @Relequestual what still needs to be done here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@philsturgeon I guess the objective of this PR is to align with the expectations of people who see this when enclosed in an OpenAPI spec document, right? As such, can you encourage someone from the OpenAPI spec team to take a little look and agree that this change meets said objective? I took a little look at the spec, but I can't see this expectation. Am I reading it wrong? Does this expectation come from somewhere else? I've made a further review. One question, one suggested language change. |
@philsturgeon @Relequestual any update on this? |
I was trying to get an OAI person to review this. I'll bump it on their slack. We'll give it a few more days then just merge. |
I've added a comment on the review. My query is regarding, if See my review comment. |
No description provided.