Skip to content

Fix Link header examples in hyper-schema #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2018
Merged

Fix Link header examples in hyper-schema #624

merged 3 commits into from
Jun 25, 2018

Conversation

dlax
Copy link
Member

@dlax dlax commented Jun 23, 2018

  • add missing semi-colons
  • quote all parameter's value (per consistency)
  • fix "anchor" by quoting value instead of enclosing between <>

Fixes #623

dlax added 3 commits June 23, 2018 11:40
@dlax
Add missing semi-colons in Link header examples
2061e5c
@dlax
Quote value of "anchor" Link header parameter
6af34b3 
The proper form for anchor value appears to be between quotes, not <>.
@dlax
Quote all link parameters in Link header examples
eba00e1 
We already had some quoted. Make things consistent by quoting them all.
@handrews handrews added this to the draft-08 milestone Jun 25, 2018
handrews
handrews approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@handrews handrews merged commit 1790b7b into json-schema-org:master Jun 25, 2018
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awwright awwright awwright approved these changes

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
clarification Items that need to be clarified in the specification
Projects
None yet
Milestone
draft-08 (2019-09)
Development

Successfully merging this pull request may close these issues.

Link header examples are not correct to RFC-5988
4 participants
@dlax @awwright @handrews @gregsdennis