Allow RFC 4648 encodings for "contentEncoding" #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 4648 is a more modern standard for encodings, and addresses ambiguities and application-specific limits of the "base64" encoding from RFC 2045. It also adds several commonly used variations, such as "base64url", that are relevant to modern systems. RFC 2045 values are still allowed, although for "base64", RFC 4648 now takes precedence.
dlax
approved these changes
Jun 14, 2018
|
@awwright @philsturgeon @Relequestual last call on this- I'll be merging it on Wednesday given @dlax's approval barring serious objections from anyone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #594
RFC 4648 is a more modern standard for encodings, and addresses
ambiguities and application-specific limits of the "base64"
encoding from RFC 2045. It also adds several commonly used
variations, such as "base64url", that are relevant to modern systems.
RFC 2045 values are still allowed, although for "base64", RFC 4648
now takes precedence.