Skip to content

Fix several early changelog oddities #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

handrews
Copy link
Contributor

The core spec's change log seemed to have been spliced across
draft-04 and draft-00. This dates back to draft-04. Move the
obviously draft-04-related stuff up to that part of the changelog,
and add a line about splitting out hypermedia (analogous to the
existing line about splitting out validation).

It did not seem worthwhile to import the old changelogs from
draft-01, -02, and -03, although we can do that if necessary.
This change just fixes things that really did not make sense.

Also, in both the validation and hyper-schema specs, the oldest
draft was erroneously numbered -01 when it should be -00.

NOTE: I'll probably also merge this to the draft-07 branch,
since if we do a bugfix this would be fine to include.

The core spec's change log seemed to have been spliced across
draft-04 and draft-00.  This dates back to draft-04.  Move the
obviously draft-04-related stuff up to that part of the changelog,
and add a line about splitting out hypermedia (analogous to the
existing line about splitting out validation).

It did not seem worthwhile to import the old changelogs from
draft-01, -02, and -03, although we can do that if necessary.
This change just fixes things that really did not make sense.

Also, in both the validation and hyper-schema specs, the oldest
draft was erroneously numbered -01 when it should be -00.
@handrews handrews requested a review from awwright November 27, 2017 21:10
Copy link
Member

@awwright awwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any clue how the entries seemingly got into the wrong heading?

@handrews
Copy link
Contributor Author

@awwright it's really not clear. It's like this in the first commit when you set up this repo. Looking at the imported commits from the old repo, the tagged commit for that draft shows just the "draft-00" entry in the changelog, and git blame shows it as fge doing it. Which means the tag is not actually on the commit that was published but I am not even going to start trying to sort that out. It's close enough.

My guess is that fge was originally going to publish a unified draft-fge-json-schema-00 document, and then they decided to split that into draft-zyp-json-schema-04, draft-fg-json-schema-validation-00, and draft-luff-json-hyper-schema-00. So viewed that way the arrangement makes sense. The draft-04 bit was a last minute insertion. But it doesn't make sense to read, so I think we're better off with this fix applied.

@handrews handrews closed this Nov 29, 2017
@handrews handrews reopened this Nov 29, 2017
@handrews handrews merged commit 1670890 into json-schema-org:master Nov 29, 2017
@handrews handrews deleted the changelog-fix branch December 25, 2017 22:06
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants