A couple of edits/fixes in hyperschema spec #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
reviewed
Nov 6, 2017
jsonschema-hyperschema.xml
Outdated
| @@ -1378,7 +1378,7 @@ for varname in templateData: | |||
| similarly structured headers wherever possible. | |||
| </t> | |||
| <t> | |||
| No distinction is made between headers that may appear in responses to | |||
| No distinction is made with headers that may appear in responses to | |||
There was a problem hiding this comment.
"with" is not the right word, but really this whole sentence is a mess so I'm not surprised you want to change something here. I'll look at it tomorrow unless you feel like a more thorough rewording.
All the rest of these changes look great
dlax
force-pushed
the
hyperschema-minor-edits
branch
from
f03e768 to
2609c89
Compare
|
"with" is not the right word, but really this whole sentence is a mess
so I'm not surprised you want to change something here. I'll look at it
tomorrow unless you feel like a more thorough rewording.
Ok, I dropped the first commit and let you work on this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.