Skip to content

Note non-anchoring of regexes in the regex section. #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

Note non-anchoring of regexes in the regex section. #1297

merged 2 commits into from
Oct 4, 2022

Conversation

handrews
Copy link
Contributor

Fixes #897

@handrews handrews added this to the draft-next milestone Sep 19, 2022
@jdesrosiers
Copy link
Member

It looks like the consensus in the linked issue was to mention it in the patternProperties keyword rather than as a general statement. It seems that if you're going to do something different, it should have some discussion.

I think having a general statement is a good idea. I don't care too much whether the keywords mention it or not, but I think they should do the same thing. Either mention anchoring or don't. Currently pattern does and patternProperties doesn't.

@handrews
Copy link
Contributor Author

There was support for both locations. I'll update patternProperties as well, but it should be in the general section (for anyone making extension keywords), and no one objected to that in the issue (in fact that is what the issue title was changed to say).

@handrews
pattern regex anchor text to patternProperties
8300dbd 
Copied the text about regexes not being anchored from "pattern"
to the analogous location in "patternProperties".
@handrews
Copy link
Contributor Author

Now it 's in both places.

@handrews handrews merged commit cdebed9 into json-schema-org:main Oct 4, 2022
@handrews handrews deleted the regex-unanchored branch October 6, 2022 16:34
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Maintenance labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesrosiers jdesrosiers jdesrosiers approved these changes

Assignees
No one assigned
Labels
clarification Items that need to be clarified in the specification core
Projects
None yet
Milestone
draft-next
Development

Successfully merging this pull request may close these issues.

Regexes should mention in its main section that they're not implicitly anchored
3 participants
@handrews @jdesrosiers @gregsdennis