Skip to content

Explain why plain name fragments are as they are #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

handrews
Copy link
Contributor

Because XML is/was the most likely need for cross-media-type fragment identifiers.

Fixes #901

@jdesrosiers
Copy link
Member

Right now, the spec is quite bloated with things that don't necessarily belong in a specification. Mostly I think that's because we didn't really have anywhere else to put things, but that's not the case anymore. This strikes me as maybe something that should be a blog post or maybe an ADR.

@handrews
Copy link
Contributor Author

@jdesrosiers I could see it as an ADR. I don't think it's actually interesting enough for a blog post. I've been thinking of writing ADRs for some decisions that people still ask about just to document them. Although sometimes trying to make it fit the ADR format when I can't even remember what the alternatives were is a bit annoying.

Because XML is/was the most likely need for cross-media-type
fragment identifiers.
In response to PR review feedback, remove the editorial explanation
and instead consolidate the fragment syntax in the section on
fragments.  The context and reason for the syntax is more clear
there with the existing text, and one additional line further
clarifies it by not just seeming to reference a random XML
syntax rule for no clear reason.
"these keywords" for both "$anchor" and "$dynamicAnchor"
@handrews
Copy link
Contributor Author

@jdesrosiers I considered making this an ADR, but it doesn't fit the format well because we kind of inherited this and assembled our own justifications for keeping it. There wasn't really a clear decision point.

I also noticed that it's weird that the Fragment Identifiers section doesn't actually define the plain name syntax, which instead appears in the section of $anchor and $dynamicAnchor, where its source is less clear.

So I've removed the editorial explanation about XML and APIs, moved the syntax up to the Fragment Identifiers section, and added one extra line so that the reason for using NCName is clear. Given the bewildering constellation of XML specifications, the additional link is, I think, useful as an informative reference. But I'm open to counter-arguments.

@handrews handrews merged commit 8d86c85 into json-schema-org:main Oct 4, 2022
@handrews handrews deleted the plain-name-frags branch October 6, 2022 16:34
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Maintenance labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to add explanation of logic behind character set choice for $anchor
3 participants