Merge draft-next to master #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
approved these changes
Jun 30, 2022
* Change URIs to IRIs where appropriate
…ons can start testing with them (json-schema-org#1148)
* Remove bookending requirement for dynamicRef * Add $dynamicRef changes to change log
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Looks like this one has been missed. Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
It is a best practice to allow callers to override the value of these program variables. For example, with this chance, you can do: ```sh make XML2RFC=/opt/bin/xml2rfc ``` See: https://www.gnu.org/software/make/manual/make.html#Command-Variables Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
I found a couple more URIs that needed to be IRIs in jsonschema-validation.xml and force pushed. |
|
|
Relequestual
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1250 that rebases draft-next and merges it back to master. As with the other PR, the conflicts were pretty nasty, so it should have careful review before merging.