Skip to content

fix the type for $recursiveAnchor #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karenetheridge
Copy link
Member

This replaces #1200, as it was decided the change cannot go into the patch release.

@jdesrosiers jdesrosiers changed the base branch from draft-next to main July 8, 2022 15:30
@jdesrosiers
Copy link
Member

The draft-next branch has been merged and is now closed. The merge target for this PR has been changed to main. Here are the recommended steps to get your branch reabsed properly.

  1. Make sure your remote for the json-schema-org/json-schema-spec repo is up-to-date. (Example: git fetch upstream).
  2. Rebase your commits onto main. (Example: git rebase --onto upstream/main abcd123~1 (replace abcd123 with the commit hash of the first commit in your PR)).
  3. Force push the rebased branch to your fork. (Example: git push --force origin my-branch).

@handrews
Copy link
Contributor

@karenetheridge if you rebase this onto main it looks like it would be a straightforward approval now, I think?

@karenetheridge karenetheridge force-pushed the ether/draft2020-12-recursiveAnchor branch from b876f29 to c028e94 Compare October 30, 2022 22:24
@karenetheridge
Copy link
Member Author

This has been rebased.

@karenetheridge karenetheridge requested a review from a team October 30, 2022 22:25
@handrews handrews merged commit d592083 into json-schema-org:main Nov 20, 2022
@karenetheridge karenetheridge deleted the ether/draft2020-12-recursiveAnchor branch April 2, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants