-
-
Notifications
You must be signed in to change notification settings - Fork 320
rc1 revisions #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc1 revisions #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change suggestion, otherwise these changes are clearly the result of deep reading and understanding. Much appreciated!
…cordingly ..also added mention of "contains" dependence on "minContains" (specifically when its value is 0)
similar changes were made in json-schema-org#787.
it is not strictly true that there will *always* be a fragment in this field: an error might occur at the schema resource root itself (for example if the subschema is "false")
keywordLocation does not always contain a relative location that actually exists in a schema - because of reference navigation, its path contains keywords from multiple locations
for example, if we start evaluating at "https://foo.com/schema.json#/$defs/Foo" and /$defs/Foo does not contain an $id keyword
54e7561
to
8cdaf1a
Compare
There was a conflict with a particular paragraph re dynamic scope that changed in a recent commit, so this is rebased to the latest master with conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, yet again!
No description provided.