This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Redirect unversioned meta-schemas #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces these with HTML stubs that will use a meta refresh tag and canonical link to perform a redirect. If there's code out there assuming that these exist and are JSON, then that code will be confused by receiving HTML. Although we do say that you can't assume these things are actually hosted. Not sure this is what anyone had in mind, though.
Because some of it is weird, and when redirecting for the JSON files, getting HTML is surprising.
|
Deploy preview for condescending-hopper-c3ed30 ready! Built with commit 7d53bd2 https://deploy-preview-300--condescending-hopper-c3ed30.netlify.com |
This is an excellent example of why using the unversioned schema URI / path is a bad idea.
|
@Relequestual any idea why the Travis job is showing up as incomplete? It looks like it completed successfully when I click through to Details. |
|
The deployment on netlify works fine (and handles the JSON better, too!). |
|
@handrews Not a clue. I've triggered a rebuild. See if that fixes it =/ |
Why do you think I'm so keen we move to netlify? |
Relequestual
approved these changes
Oct 31, 2019
|
@awwright any thoughts on this? @Relequestual approved it, if I don't hear from you after a couple more days I'll merge this. |
awwright
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces these with HTML stubs that will use a meta refresh
tag and canonical link to perform a redirect.
If there's code out there assuming that these exist and are JSON,
then that code will be confused by receiving HTML. Although we do
say that you can't assume these things are actually hosted.
Not sure this is what anyone had in mind, though.
Also explain the redirects some in the template, because
some of it is weird, and when redirecting for the JSON
files, getting HTML is surprising.
Also, as an example of this problem, the tests of the examples
against the meta-schema were failing because they were using
the unversioned meta-schema, which of course no longer makes
sense as neither the examples nor the validator have been updated.